Review request: JDK-8014394 (fs) WatchService failing when watching \\server\$d

Alan Bateman Alan.Bateman at oracle.com
Thu May 23 11:54:45 PDT 2013


On 23/05/2013 14:02, Alexey Utkin wrote:
> :
>
> Yes, you are right. Only for new. I missed the first search by FileKey 
> instance.
> But, jobject is a good completion key.
>
I don't think a jobject will work here, at least not without creating a 
JNI global ref per Path to each directory (which we don't want to do).

I've looked at the latest webrev and it mostly looks good.

In Poller you have a comment that links to a random blog on 
ReadDirectoryChangesW, I think we should remove that because the link 
could easily break and also may not be authoritative. In the processing 
of the error (in Poller.run) then I think we should braces in the 
if-then-else, just because the comments make it multiple lines.

-Alan.


More information about the nio-dev mailing list