Review request: JDK-8014394 (fs) WatchService failing when watching \\server\$d (v.3)

[Alexey Utkin]

On 5/23/2013 10:54 PM, Alan Bateman wrote:
> On 23/05/2013 14:02, Alexey Utkin wrote:
>> :
>>
>> Yes, you are right. Only for new. I missed the first search by 
>> FileKey instance.
>> But, jobject is a good completion key.
>>
> I don't think a jobject will work here, at least not without creating 
> a JNI global ref per Path to each directory (which we don't want to do).
>
Accepted.
> I've looked at the latest webrev and it mostly looks good.
>
> In Poller you have a comment that links to a random blog on 
> ReadDirectoryChangesW, I think we should remove that because the link 
> could easily break and also may not be authoritative. 
Removed.
> In the processing of the error (in Poller.run) then I think we should 
> braces in the if-then-else, just because the comments make it multiple 
> lines.
>
Done.

New version:
http://cr.openjdk.java.net/~uta/openjdk-webrevs/JDK-8014394/webrev.02/

-uta