8028792: (ch) Channels native code needs to be checked for methods calling JNI with pending excepitons

Alan Bateman Alan.Bateman at oracle.com
Mon Feb 3 04:43:00 PST 2014


On 03/02/2014 11:02, Volker Simonis wrote:
> Hi Alan,
>
> I've just checked your change on AIX (with 'init()' changed to return
> void - see attached patch) an couldn't find any problem. So from the
> AIX side, this change is fine.
Thanks for the checking. I've refreshed the webrev [1] so that it 
includes this update.

>
> :
> No big deal. I just realized that there are differences between the
> usage patterns on Windows/Unix/AIX and the ones on Linux/BSD/Solaris
> and I more liked the first ones. But I'm fine with t he other version
> as well.
I've changed the Linux/BSD/Solaris versions so that they should all be 
consistent now. The only places where the CHECK_NULL(id = GetXXX) style 
remains is in very trivial init methods.

I'll need to double check that the updated version build + passes tests 
on all platforms and once that is done then I think we are good to go.

-Alan.

[1] http://cr.openjdk.java.net/~alanb/8028792/webrev/


More information about the nio-dev mailing list