8028792: (ch) Channels native code needs to be checked for methods calling JNI with pending excepitons

[Volker Simonis]

Hi Alan,

I've just checked your change on AIX (with 'init()' changed to return
void - see attached patch) an couldn't find any problem. So from the
AIX side, this change is fine.

On Mon, Feb 3, 2014 at 9:29 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> On 03/02/2014 08:21, Volker Simonis wrote:
>>
>> :
>>
>>
>> Hi Alan,
>> thanks a lot for taking care of the AIX file as well. I think the changes
>> are OK, but for all cases I'll do test build tomorrow and let you know.
>>
>> You're also right that we can make the init method void and I'd appreciate
>> it if you could add that to your change in order to align the different
>> platform implementations.
>
> Will do.
>
>
>>
>> One other thing I'd like to suggest is to use a uniform usage pattern of
>> the CHECK macros on all platform. While slightly more verbose, I'd
>> personally prefer the pattern currently used in the Windows/Unix/AIX files
>> where the macros are on a separate line and check the value of the class
>> members:
>
> I deliberated just put the CHECK_NULL around each because it is neater. Is
> this a big deal? There aren't other macros involved so it shouldn't be too
> complicated.

No big deal. I just realized that there are differences between the
usage patterns on Windows/Unix/AIX and the ones on Linux/BSD/Solaris
and I more liked the first ones. But I'm fine with t he other version
as well.

Regards,
Volker

>
> -Alan.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 8028792_aix.patch
Type: text/x-patch
Size: 1963 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20140203/4a0f5317/8028792_aix.patch