RFR for JDK-8031563: TEST_BUG: java/nio/channels/Selector/ChangingInterests.java failed once

Alan Bateman Alan.Bateman at oracle.com
Thu Feb 13 04:15:18 PST 2014


On 12/02/2014 13:34, michael cui wrote:
> :
> Comments from Shura :
>           I have concern about two areas which might make your version 
> and original version not equivalent.
>           one is  code changes in verification logic are different.
>           the other is old version called selectNow() only once, your 
> version replace it by calling it repeatedly in worst case.
>
> Both fixes were tested on 4 platforms (win, linux, mac, solaris)for 
> 2000 runs without seeing any error.
>
> Any suggestion?
>
I plan to look at this soon but I have a concern that it is changing the 
test so that the change from OP_READ to OP_READ|OP_WRITE no longer tests 
that the key is both readable and writable after one select.

-Alan


More information about the nio-dev mailing list