RFR 9 8062501: Modifications of server socket channel accept() methods for instrumentation purposes

Chris Hegarty chris.hegarty at oracle.com
Thu Oct 30 15:38:04 UTC 2014


Apart from the indentation of the new method parameters, this looks fine to me.

To keep the style consistent, just indent the params inline with the first param on the previous line. And fix up the throws

e.g.

  private int accept(FileDescriptor ssfd, FileDescriptor newfd,
                              InetSocketAddress[] isaa)
      throws IOException
  {
      return accept0(ssfd, newfd, isaa);
  }

-Chris.

On 29 Oct 2014, at 21:35, Brian Burkhalter <brian.burkhalter at oracle.com> wrote:

> Hello,
> 
> Please review this proposed change:
> 
> Issue:	https://bugs.openjdk.java.net/browse/JDK-8062501
> Patch:	http://cr.openjdk.java.net/~bpb/8062501/webrev.00/
> 
> With this change the jdk_nio tests pass on all platforms.
> 
> This is similar to a previously discussed change to Java I/O:
> 
> http://mail.openjdk.java.net/pipermail/core-libs-dev/2014-August/028301.html
> 
> Thanks,
> 
> Brian



More information about the nio-dev mailing list