RFR 9 8062501: Modifications of server socket channel accept() methods for instrumentation purposes
Brian Burkhalter
brian.burkhalter at oracle.com
Thu Oct 30 15:52:39 UTC 2014
Hi Chris,
Thanks for the review. The patch is modified as requested here:
http://cr.openjdk.java.net/~bpb/8062501/webrev.01/
Please verify that this is approved to check in to 9.
Thanks,
Brian
On Oct 30, 2014, at 8:38 AM, Chris Hegarty <chris.hegarty at oracle.com> wrote:
> Apart from the indentation of the new method parameters, this looks fine to me.
>
> To keep the style consistent, just indent the params inline with the first param on the previous line. And fix up the throws
>
> e.g.
>
> private int accept(FileDescriptor ssfd, FileDescriptor newfd,
> InetSocketAddress[] isaa)
> throws IOException
> {
> return accept0(ssfd, newfd, isaa);
> }
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20141030/237bbadd/attachment.html>
More information about the nio-dev
mailing list