[9] RFR of 8139133: Changing the modification time on a unix domain socket file fails

[Alan Bateman]

On 09/12/2015 01:03, Brian Burkhalter wrote:
>
> UnixNativeDispatcher modified accordingly.
This looks good now. To be consistent then close0 can be private and the 
declaration moved to below close (you'll see this convention is used in 
this source file). No need for an updated webrev on this.


> :
>
>> The test is still a concern, esp. the sleep.
>
> Excised the sleep calls. The existence of the socket file is 
> determined instead by creating it in a new subdirectory of the test 
> directory and monitoring the subdirectory for new entries using a 
> WatchService. Don’t know whether this is the best way to handle it but 
> it works.
>
Looks better but I worry about the reliability of tests like this. I 
don't object to you pushing this, you just might want to fix up some of 
the odd line breaks to make it looks a bit nicer before pushing.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20151210/6d8bc462/attachment.html>