[9] RFR of 8139133: Changing the modification time on a unix domain socket file fails

[Brian Burkhalter]

On Dec 10, 2015, at 2:35 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

>> UnixNativeDispatcher modified accordingly.
> This looks good now. To be consistent then close0 can be private and the declaration moved to below close (you'll see this convention is used in this source file). No need for an updated webrev on this.

Modified as suggested.

>> Excised the sleep calls. The existence of the socket file is determined instead by creating it in a new subdirectory of the test directory and monitoring the subdirectory for new entries using a WatchService. Don’t know whether this is the best way to handle it but it works.
>> 
> Looks better but I worry about the reliability of tests like this. I don't object to you pushing this, you just might want to fix up some of the odd line breaks to make it looks a bit nicer before pushing.


Went back over the code and added a number of comments and format improvement; looks much better now.

The patch has been pushed.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20151210/0ab8200c/attachment.html>