RFR 8144355: JDK 9 changes to ZipFileSystem to support multi-release jar files

Steve Drach steve.drach at oracle.com
Tue Dec 22 18:11:14 UTC 2015


>>>> I updated the patch to the changeset to address Paul’s concern with a windows specific solution, as well some of Alan’s concerns.  Please let me know if this patch (instead of the previous one) can be applied to the changeset.
>>>> 
>>>> Thanks
>>>> Steve
>>> Would it be possible to refresh the webrev? The patch you inlined adjusts comments and fixes the issue with the test on Windows but it's hard to see everything (like getting JarFileSystem consistent with ZipFileSystem and I think whether we should rename getEntry0 because it looks strange that this is not private).
>> Sure I can refresh the webrev today.  I didn’t rename getEntry0 because that name is in ZipFileSystem and I assume it was chosen, instead of getEntry, for a reason.  Perhaps Sherman can shed some light on that.  The reason that it is not private is because JarFileSystem invokes ZipFileSystem.newInputStream, and that invokes getEntry0.
> let's rename getEntry0 to getEntry(), given it's no longer a private method now. There
> was another getEntry() in the early version of ZFS, but it does not matter any more.

Okay, I did that.  The patch is attached.  It contains only the change from getEntry0 to getEntry.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: getEntry.patch
Type: application/octet-stream
Size: 7123 bytes
Desc: not available
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20151222/27209df6/getEntry.patch>


More information about the nio-dev mailing list