[9] RFR(S): 8164649: Cleanup of test java/nio/channels/FileChannel/Lock.java

Alan Bateman Alan.Bateman at oracle.com
Thu Aug 25 19:58:22 UTC 2016


On 24/08/2016 23:11, Langer, Christoph wrote:

> Hi Alan,
>
> thanks for looking into this.
>
> See my new vebrev: 
> http://cr.openjdk.java.net/~clanger/webrevs/8164649.2/ 
> <http://cr.openjdk.java.net/%7Eclanger/webrevs/8164649.2/>
>
> I’ve implemented all suggestions, except for line 89 where I don’t 
> know how it should be done better…
>
>
Thanks for this, it looks much cleaned now. For L89 and L102 then you 
could split it into two statements to about the break - but what you 
have is okay, it's not worth spending time on.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20160825/075b67c0/attachment.html>


More information about the nio-dev mailing list