[9] RFR(S): 8164649: Cleanup of test java/nio/channels/FileChannel/Lock.java

[Langer, Christoph]

Hi Alan,

the change is pushed now: http://hg.openjdk.java.net/jdk9/dev/jdk/rev/2c68a91dcecf

I have split lines 89 and 102 into two statements - hope this is more to your like. It's really hard to do that while keeping the 80 columns per line limit...

Thanks again and best regards
Christoph

From: Alan Bateman [mailto:Alan.Bateman at oracle.com]
Sent: Donnerstag, 25. August 2016 21:58
To: Langer, Christoph <christoph.langer at sap.com>; nio-dev at openjdk.java.net
Subject: Re: [9] RFR(S): 8164649: Cleanup of test java/nio/channels/FileChannel/Lock.java


On 24/08/2016 23:11, Langer, Christoph wrote:
Hi Alan,

thanks for looking into this.

See my new vebrev: http://cr.openjdk.java.net/~clanger/webrevs/8164649.2/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8164649.2/>

I've implemented all suggestions, except for line 89 where I don't know how it should be done better...

Thanks for this, it looks much cleaned now. For L89 and L102 then you could split it into two statements to about the break - but what you have is okay, it's not worth spending time on.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20160829/9b325340/attachment.html>