RFR: 8146213, 8133093: java/nio/channels/ServerSocketChannel/AdaptServerSocket.java failed intermittently with Connection refused and Accept did not time out

[Alan Bateman]

On 14/01/2016 23:02, Brian Burkhalter wrote:
> Hi Hamlin,
>
> On Jan 13, 2016, at 7:32 PM, Hamlin Li <huaming.li at oracle.com 
> <mailto:huaming.li at oracle.com>> wrote:
>
>> Would you please help to review the fix for below bugs?
>> https://bugs.openjdk.java.net/browse/JDK-8146213, Test 
>> java/nio/channels/ServerSocketChannel/AdaptServerSocket.java failed 
>> intermittently with Connection refused,
>> andhttps://bugs.openjdk.java.net/browse/JDK-8133093, Test 
>> java/nio/channels/ServerSocketChannel/AdaptServerSocket.java failed 
>> with Accept did not time out.
>>
>> webrev :http://cr.openjdk.java.net/~mli/8146213/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Emli/8146213/webrev.00/>
>
> This looks OK to me aside from the following two points:
>
Hamlin - would it be possible to summarize what the issue this? This is 
a very old test and would be good to have this information to understand 
what the issue is?

Also just to say that it's best to keep the coding style consistent when 
you can.

-Alan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20160115/cfd08c42/attachment-0001.html>