JDK 9 RFR of 8152043: (fs) Remove dynamic loopup of Win32 API functions in WindowsNativeDispatcher needed to support Windows XP and Server 2003
Alan Bateman
Alan.Bateman at oracle.com
Thu Mar 17 07:02:43 UTC 2016
On 16/03/2016 22:34, Brian Burkhalter wrote:
> Please review at your convenience:
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8152043
> Patch: http://cr.openjdk.java.net/~bpb/8152043/webrev.00/
>
This looks good. As you say, this dates back to when we had to support
older versions of Windows. There more than can be done to remove support
for older Windows but this is a great start.
>
> Running the NIO regression tests did not reveal any problems either building or testing.
>
> The issue ID 8152043 is added to the @bug tag in each of the two tests because test/java/nio/file/Files/CheckPermissions.java indirectly exercises the Win32 API functions CreateSymbolicLinkW() and GetFinalPathNameByHandleW(), and test/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java likewise indirectly exercises FindFirstStreamW() and FindNextStreamW().
>
I would skip this part, instead add the noreg-other label to the bug.
-Alan
More information about the nio-dev
mailing list