JDK 9 RFR of 8152043: (fs) Remove dynamic loopup of Win32 API functions in WindowsNativeDispatcher needed to support Windows XP and Server 2003

[Brian Burkhalter]

On Mar 17, 2016, at 12:02 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

>> Please review at your convenience:
>> 
>> Issue:	https://bugs.openjdk.java.net/browse/JDK-8152043
>> Patch:	http://cr.openjdk.java.net/~bpb/8152043/webrev.00/
>> 
> This looks good. As you say, this dates back to when we had to support older versions of Windows. There more than can be done to remove support for older Windows but this is a great start.

I should investigate that aspect further.

>> Running the NIO regression tests did not reveal any problems either building or testing.
>> 
>> The issue ID 8152043 is added to the @bug tag in each of the two tests because test/java/nio/file/Files/CheckPermissions.java indirectly exercises the Win32 API functions CreateSymbolicLinkW() and GetFinalPathNameByHandleW(), and test/java/nio/file/attribute/UserDefinedFileAttributeView/Basic.java likewise indirectly exercises FindFirstStreamW() and FindNextStreamW().
>> 
> I would skip this part, instead add the noreg-other label to the bug.

I was not sure. I rather miss the “noreg-existing” label.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20160317/e02df9b8/attachment.html>