RFR 8191872: (fs) UnixNativeDispatcher conditionally compiles in support for high precision timestamps

Alan Bateman Alan.Bateman at oracle.com
Wed Dec 6 19:27:19 UTC 2017



On 06/12/2017 18:03, Brian Burkhalter wrote:
> https://bugs.openjdk.java.net/browse/JDK-8191872
> http://cr.openjdk.java.net/~bpb/8191872/webrev.00/
>
> 1. Add conditional compilation branch for macOS to support higher precision so Files.getLastModifiedTime() has the same milliseconds precision as File.lastModified() which was already updated in JDK 10 [1].
> 2. Remove conditional compilation restriction on non-macOS Unix, i.e., (_POSIX_C_SOURCE >= 200809L) || defined(solaris).
>
The implementation changes looks good.

Are you sure that the test is reliable on Windows? I don't know if 
anyone runs these tests on FAT32 but I assume it will fail there.

-Alan


More information about the nio-dev mailing list