RFR 8191872: (fs) UnixNativeDispatcher conditionally compiles in support for high precision timestamps

[Brian Burkhalter]

On Dec 6, 2017, at 11:27 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> On 06/12/2017 18:03, Brian Burkhalter wrote:
>> https://bugs.openjdk.java.net/browse/JDK-8191872
>> http://cr.openjdk.java.net/~bpb/8191872/webrev.00/
>> 
>> 1. Add conditional compilation branch for macOS to support higher precision so Files.getLastModifiedTime() has the same milliseconds precision as File.lastModified() which was already updated in JDK 10 [1].
>> 2. Remove conditional compilation restriction on non-macOS Unix, i.e., (_POSIX_C_SOURCE >= 200809L) || defined(solaris).
>> 
> The implementation changes looks good.
> 
> Are you sure that the test is reliable on Windows? I don't know if anyone runs these tests on FAT32 but I assume it will fail there.

I have not tried FAT32 but it succeeds on all platforms in our regression harness. I did test it on macOS using NFS to verify the higher precision was working correctly.

Is it worth testing on FAT32?

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20171206/ecd45ca4/attachment.html>