RFR(S): 8184330: Remove sun.nio.ch.Util.atBugLevel() either completely or at least get rid of volatile field bugLevel

Alan Bateman Alan.Bateman at oracle.com
Thu Jul 13 11:14:09 UTC 2017



On 13/07/2017 11:29, Langer, Christoph wrote:
>
> Hi,
>
> after getting in the fix for JDK-8182743 [1] that removes 
> “sun.nio.cs.bugLevel”, I’m taking on Claes‘ suggestion [2]  to also 
> tackle “sun.nio.ch.bugLevel”. The bugLevel check is done to enable 
> some JDK 1.4 compatible mode which I hope is safe to be dropped with 
> JDK10. Unfortunately I didn’t find the bug that introduced 
> “sun.nio.cs.bugLevel”, maybe someone can shed some more light on its 
> history. I’m hoping that it’s ok to remove this one as well. If there 
> are no objections and I get it reviewed then I’ll open a CSR request.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8184330 
> <https://bugs.openjdk.java.net/browse/JDK-8184330>
>
> Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8184330.0/ 
> <http://cr.openjdk.java.net/%7Eclanger/webrevs/8184330.0/>
>
>
Looks okay except you've removed a blank line from SelectorImpl. If you 
can fix that then it looks okay.

-Alan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170713/3badc74d/attachment-0001.html>


More information about the nio-dev mailing list