RFR(S): 8184330: Remove sun.nio.ch.Util.atBugLevel() either completely or at least get rid of volatile field bugLevel

[Langer, Christoph]

Hi Alan,

thanks. I have updated the webrev in place.

As for documentation/bugids: I found that one: http://www.oracle.com/technetwork/java/javase/compatibility-417013.html. However, the text in there seems not to be quite correct (any more) as it talks about bugLevel could be set to "1.4", "1.5" or "1.6" - which you can do but obviously has no effect. And the referenced bug (https://bugs.openjdk.java.net/browse/JDK-6621689) does not talk about "sun.nio.ch.bugLevel". Are you aware of any more information that I can use for the CSR?

Best regards
Christoph


From: Alan Bateman [mailto:Alan.Bateman at oracle.com]
Sent: Donnerstag, 13. Juli 2017 13:14
To: Langer, Christoph <christoph.langer at sap.com>; nio-dev at openjdk.java.net
Subject: Re: RFR(S): 8184330: Remove sun.nio.ch.Util.atBugLevel() either completely or at least get rid of volatile field bugLevel


On 13/07/2017 11:29, Langer, Christoph wrote:
Hi,

after getting in the fix for JDK-8182743 [1] that removes "sun.nio.cs.bugLevel", I'm taking on Claes' suggestion [2]  to also tackle "sun.nio.ch.bugLevel". The bugLevel check is done to enable some JDK 1.4 compatible mode which I hope is safe to be dropped with JDK10. Unfortunately I didn't find the bug that introduced "sun.nio.cs.bugLevel", maybe someone can shed some more light on its history. I'm hoping that it's ok to remove this one as well. If there are no objections and I get it reviewed then I'll open a CSR request.

Bug: https://bugs.openjdk.java.net/browse/JDK-8184330
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8184330.0/<http://cr.openjdk.java.net/%7Eclanger/webrevs/8184330.0/>

Looks okay except you've removed a blank line from SelectorImpl. If you can fix that then it looks okay.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170713/cedb3276/attachment.html>