Proposal for adding O_DIRECT support into JDK 9
Brian Burkhalter
brian.burkhalter at oracle.com
Wed Sep 13 23:20:57 UTC 2017
Hi Lucy,
On Sep 13, 2017, at 9:52 AM, Lu, Yingqi <yingqi.lu at intel.com> wrote:
> Please find the most recent version of the patch is available athttp://cr.openjdk.java.net/~kkharbas/8164900/webrev.11/
GensrcMisc.gmk and UnixConstants.java.template
2: Copyright year 2016 -> 2017
jtregNative.gmk
66: Is the “-lc” necessary?
FileStore.java
116: “stoage” -> “storage” (missing an “r”)
> In this version, I fixed the typos in the FileStore:getBlockSize. I also removed alignment checks with checkBufferPositionAligned and checkRemainingBufferSizeAligned from FileChannelImpl (only have them in IOUtil), but still keep checkChannelPositionAligned there. This way, I think the duplicated checks are removed. Please let me know if I miss anything.
I don’t see any obvious problems. I have not been able to test it today due to some problem with my connection; will try again tomorrow.
Thanks,
Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170913/83e41ed1/attachment.html>
More information about the nio-dev
mailing list