Proposal for adding O_DIRECT support into JDK 9

[Lu, Yingqi]

Hi Brian,

Thank you for the feedback. Here is a newer version of the patch http://cr.openjdk.java.net/~kkharbas/8164900/webrev.12/

Please let me know if you find anything unexpected from the testing.

Thanks,
Lucy

From: Brian Burkhalter [mailto:brian.burkhalter at oracle.com]
Sent: Wednesday, September 13, 2017 4:21 PM
To: Lu, Yingqi <yingqi.lu at intel.com>
Cc: nio-dev at openjdk.java.net
Subject: Re: Proposal for adding O_DIRECT support into JDK 9

Hi Lucy,

On Sep 13, 2017, at 9:52 AM, Lu, Yingqi <yingqi.lu at intel.com<mailto:yingqi.lu at intel.com>> wrote:


Please find the most recent version of the patch is available athttp://cr.openjdk.java.net/~kkharbas/8164900/webrev.11/

GensrcMisc.gmk and UnixConstants.java.template
2:       Copyright year 2016 -> 2017

jtregNative.gmk
66:     Is the "-lc" necessary?

FileStore.java
116:   "stoage" -> "storage" (missing an "r")

In this version, I fixed the typos in the FileStore:getBlockSize. I also removed alignment checks with checkBufferPositionAligned and checkRemainingBufferSizeAligned from FileChannelImpl (only have them in IOUtil), but still keep checkChannelPositionAligned there. This way, I think the duplicated checks are removed. Please let me know if I miss anything.

I don't see any obvious problems. I have not been able to test it today due to some problem with my connection; will try again tomorrow.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170913/5df8ae97/attachment-0001.html>