Proposal for adding O_DIRECT support into JDK 9

[Alan Bateman]

On 14/09/2017 00:50, Lu, Yingqi wrote:
>
> Hi Brian,
>
> Thank you for the feedback. Here is a newer version of the patch 
> http://cr.openjdk.java.net/~kkharbas/8164900/webrev.12/ 
> <http://cr.openjdk.java.net/%7Ekkharbas/8164900/webrev.12/>
>
Just catching up on this again.

The check for alignment of the position and size of the remaining in 
readInto/writeFrom{NativeBuffer} looks right now. There is still a 
duplicate check in FileChannelImpl.read/write that I assume can be 
removed (it is easily defeated). I assume the protected modifier can be 
dropped from the new check methods in Util.

It looks like the first sentence in the FileStore::getBlockSize javadoc 
has been dropped in this version. A sentence to say that to returns the 
block size would be good to have as the first sentence.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20170914/e312b770/attachment.html>