adding rsockets support into JDK

Chris Hegarty chris.hegarty at oracle.com
Wed Dec 5 14:39:03 UTC 2018


Lucy,

> On 5 Dec 2018, at 05:15, Lu, Yingqi <yingqi.lu at intel.com> wrote:
> ...
>  
> 3.      I took a look at the first issue you found regarding to socket channel read does not return EOF at the end. I found that issue might not related to the current patch. I tested regular TCP socket channel with both JDK11 and current trunk and I saw the exact same issue.


I should have spotted this earlier! The test creates a buffer with just
enough space for the expected message. When the complete message has
been received, the read method will return 0 since there is not enough
space in the buffer, even though the only remaining data to read is
EOF. I fixed this in the test and added a few more assertions for the
shutdown states.

  https://cr.openjdk.java.net/~chegar/rsocket/webrev.24.1/
  
-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20181205/c7cd93ad/attachment.html>


More information about the nio-dev mailing list