adding rsockets support into JDK

[Lu, Yingqi]

Hi Chris,

That totally explains it! Thank you for the help! I already applied the patch locally.

I am waiting for more feedback before doing version 25 of the patch.

Thanks,
Lucy

From: Chris Hegarty [mailto:chris.hegarty at oracle.com]
Sent: Wednesday, December 5, 2018 6:39 AM
To: Lu, Yingqi <yingqi.lu at intel.com>
Cc: Brian Burkhalter <brian.burkhalter at oracle.com>; Aundhe, Shirish <shirish.aundhe at intel.com>; Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; nio-dev at openjdk.java.net; Kaczmarek, Eric <eric.kaczmarek at intel.com>
Subject: Re: adding rsockets support into JDK

Lucy,


On 5 Dec 2018, at 05:15, Lu, Yingqi <yingqi.lu at intel.com<mailto:yingqi.lu at intel.com>> wrote:
...

3.      I took a look at the first issue you found regarding to socket channel read does not return EOF at the end. I found that issue might not related to the current patch. I tested regular TCP socket channel with both JDK11 and current trunk and I saw the exact same issue.

I should have spotted this earlier! The test creates a buffer with just
enough space for the expected message. When the complete message has
been received, the read method will return 0 since there is not enough
space in the buffer, even though the only remaining data to read is
EOF. I fixed this in the test and added a few more assertions for the
shutdown states.

  https://cr.openjdk.java.net/~chegar/rsocket/webrev.24.1/

-Chris
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20181205/c403e6e5/attachment.html>