8199791: (se) More Selector cleanup

Alan Bateman Alan.Bateman at oracle.com
Thu Mar 22 13:41:28 UTC 2018


On 22/03/2018 00:29, Brian Burkhalter wrote:
> I concur about nanoTime() and eventfd seems like a good idea for the 
> reasons stated in another message but these could be done separately 
> at a later time.
I'm happy to change that in this patch.

>
> Just a few comments:
>
> EPollPort
> 33: Could this static import be removed?
Okay..


> 92: Could the socket pair creation be moved to just after super()? If 
> so then the try-catch could be eliminated and there would be no need 
> for the current lines 96-97.
That wouldn't help as a try/catch would still be needed to close both 
ends of the socket pair in the event that creating the kqueue or epoll 
instance fails.


>
> :
>
> Could DevPollArrayWrapper be dispensed with similarly to 
> {EPoll,KQueue}ArrayWrapper?
That's for another patch. I have a lot of changes in this area so I'm 
trying to keep the patches down to a reasonable size to ensure that the 
changes are over a number of builds, and also to make the changes a bit 
easier to review.

I've updated the patch in place and hopefully the changes looks okay now.

-Alan


More information about the nio-dev mailing list