8199791: (se) More Selector cleanup

[Brian Burkhalter]

On Mar 22, 2018, at 6:41 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

>> 92: Could the socket pair creation be moved to just after super()? If so then the try-catch could be eliminated and there would be no need for the current lines 96-97.
> That wouldn't help as a try/catch would still be needed to close both ends of the socket pair in the event that creating the kqueue or epoll instance fails.

I see what you are saying. It’s OK then.

>> Could DevPollArrayWrapper be dispensed with similarly to {EPoll,KQueue}ArrayWrapper?
> That's for another patch. I have a lot of changes in this area so I'm trying to keep the patches down to a reasonable size to ensure that the changes are over a number of builds, and also to make the changes a bit easier to review.

Understood.

> I've updated the patch in place and hopefully the changes looks okay now.

This looks fine to me now.

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180322/6ad6a84b/attachment.html>