adding rsockets support into JDK

[Lu, Yingqi]

Hi Paul,

Thank you very much for your feedback. I will modify accordingly.

Thanks,
Lucy

>-----Original Message-----
>From: Paul Sandoz [mailto:paul.sandoz at oracle.com]
>Sent: Thursday, May 17, 2018 4:10 PM
>To: Lu, Yingqi <yingqi.lu at intel.com>
>Cc: Alan Bateman <Alan.Bateman at oracle.com>; nio-dev at openjdk.java.net;
>Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; Aundhe, Shirish
><shirish.aundhe at intel.com>; Kaczmarek, Eric <eric.kaczmarek at intel.com>
>Subject: Re: adding rsockets support into JDK
>
>Hi Lucy,
>
>For now i will just focus on the Summary and Description as those are the
>most important. Alan et. al. are more qualified than I to talk about the
>specifics.
>
>I would like to suggest an alternative title:
>
>  Socket API for Remote Direct Memory Access (RDMA)
>
>with the proposed summary:
>
>"Enhance the Java Socket API to support Remote Direct Memory Access
>(RDMA) using the rsocket protocol on the Linux-based platforms."
>
>In the Motivation section you could expand the last sentence to:
>
>"To improve this, we propose to add rsocket, a protocol over Remote Direct
>Memory Access (RDMA) that permits high-throughput, low-latency
>networking.”
>
>s/For HPC and.../High Performance Computing (HPC)…/
>
>Paul.
>
>
>> On May 16, 2018, at 9:03 PM, Lu, Yingqi <yingqi.lu at intel.com> wrote:
>>
>> Hi Paul,
>>
>> Thank you for your email! Looking forward to your feedback!
>>
>> Thanks,
>> Lucy
>>
>>> -----Original Message-----
>>> From: Paul Sandoz [mailto:paul.sandoz at oracle.com]
>>> Sent: Wednesday, May 16, 2018 4:47 PM
>>> To: Lu, Yingqi <yingqi.lu at intel.com>
>>> Cc: Alan Bateman <Alan.Bateman at oracle.com>; nio-
>dev at openjdk.java.net;
>>> Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; Aundhe,
>Shirish
>>> <shirish.aundhe at intel.com>; Kaczmarek, Eric
>>> <eric.kaczmarek at intel.com>
>>> Subject: Re: adding rsockets support into JDK
>>>
>>>
>>>
>>>> On May 16, 2018, at 12:26 PM, Lu, Yingqi <yingqi.lu at intel.com> wrote:
>>>>
>>>> Hi All,
>>>>
>>>> I have just submitted the initial JEP draft at
>>> https://bugs.openjdk.java.net/browse/JDK-8203314 and linked it to the
>>> bug JDK-8195160.
>>>>
>>>
>>> Great!
>>>
>>>
>>>> Do I also need to submit a PDF version to
>>>> jep-submit at openjdk.java.net or
>>> jdk-dev email list?
>>>>
>>>
>>> When you think the JEP is of suitable draft quality send an email to
>>> jdk- dev at openjdk.java.net (e.g. titled Draft JEP: <title>) to solicit
>>> wider comments beyond this list. This is an informal but encouraged
>>> polite step to inform the wider community, where further comments can
>>> be taken into account, and it will reduce potential surprises for the next
>formal step of JEP submission.
>>>
>>>
>>>> Please review the JEP draft and let me know your comments and
>feedback.
>>>>
>>>
>>> I shall do so this week.
>>>
>>> Thanks,
>>> Paul.
>>>
>>>> Thanks you!!
>>>>
>>>> Lucy
>>>>
>>>>> -----Original Message-----
>>>>> From: nio-dev [mailto:nio-dev-bounces at openjdk.java.net] On Behalf
>>>>> Of Lu, Yingqi
>>>>> Sent: Sunday, May 13, 2018 7:48 AM
>>>>> To: Alan Bateman <Alan.Bateman at oracle.com>
>>>>> Cc: nio-dev at openjdk.java.net; Viswanathan, Sandhya
>>>>> <sandhya.viswanathan at intel.com>; Aundhe, Shirish
>>>>> <shirish.aundhe at intel.com>; Kaczmarek, Eric
>>>>> <eric.kaczmarek at intel.com>
>>>>> Subject: Re: adding rsockets support into JDK
>>>>>
>>>>> Yes! Will submit early next week. Thank you for the reminder.
>>>>>
>>>>> Thanks,
>>>>> Lucy
>>>>>
>>>>> Sent from my iPhone
>>>>>
>>>>>> On May 13, 2018, at 1:11 AM, Alan Bateman
>>>>>> <Alan.Bateman at oracle.com>
>>>>> wrote:
>>>>>>
>>>>>>> On 11/05/2018 17:37, Lu, Yingqi wrote:
>>>>>>> Hi Alan,
>>>>>>>
>>>>>>> Thank you very much for your feedback!
>>>>>>>
>>>>>>> I agree that jdk.net.RdmaSocketImplFactory is not necessary
>>>>>>> anymore. I
>>>>> will remove it in next version.
>>>>>>>
>>>>>>> I will remove the inheritance from
>>>>> SocketChannelImpl/ServerSocketChannelImpl, replace them with
>>>>> SocketChannel/ServerSocketChannel. My initial thought was to avoid
>>>>> the code duplication, but I totally agree with you on your concern
>>>>> for future maintenance.
>>>>>>>
>>>>>>> I will also make other changes following your suggestions and
>>>>>>> start to add
>>>>> test cases. I will start from the examples of regular sockets and
>>>>> socket channels and add ones specific to RDMA.
>>>>>> Are you still planning to submit a JEP?
>>>>>>
>>>>>> -Alan
>>