8201407: Files.move throws DirectoryNonEmptyException when moving directory across file system

Alan Bateman Alan.Bateman at oracle.com
Fri May 25 13:03:31 UTC 2018


On 25/05/2018 01:30, Brian Burkhalter wrote:
>
> An updated version is at 
> http://cr.openjdk.java.net/~bpb/8201407/webrev.01/ 
> <http://cr.openjdk.java.net/%7Ebpb/8201407/webrev.01/>.
>
> Note that the test will still fail for different reasons when 
> -Dtest.dir specifies a different device. This is tracked by [1].
>
This version looks a lot better. I think the spec update is okay.

The implementation changes would be cleaner if we add an isEmptyDir 
method. Also in the Windows implementation would be easier to read if 
you specify the filter as `e -> true`.

I wasn't aware that setting -Dtest.dir to a different file system breaks 
this test. This was an important testing mode when this test was 
originally created.

-Alan.


More information about the nio-dev mailing list