8201407: Files.move throws DirectoryNonEmptyException when moving directory across file system

Brian Burkhalter brian.burkhalter at oracle.com
Fri May 25 14:05:43 UTC 2018


On May 25, 2018, at 6:03 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:

> This version looks a lot better. I think the spec update is okay.
> 
> The implementation changes would be cleaner if we add an isEmptyDir method. Also in the Windows implementation would be easier to read if you specify the filter as `e -> true`.

I will look at the foregoing next week.

> I wasn't aware that setting -Dtest.dir to a different file system breaks this test. This was an important testing mode when this test was originally created.

I don’t imagine that -Dtest.dir is a scenario typically run in CI builds. Something needs to be figured out here to make it get executed at least occasionally by default.

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20180525/dfd2b2d4/attachment.html>


More information about the nio-dev mailing list