adding rsockets support into JDK

Brian Burkhalter brian.burkhalter at oracle.com
Fri Oct 26 19:01:35 UTC 2018


Hi Lucy,

For now, just a few minor points regarding the API verbiage.

1. jdk.net <http://jdk.net/>.Sockets

474: I think “server-socket” should have the hyphen removed: “server socket”.

2. jdk.net <http://jdk.net/>.RdmaSocketOptions

67, 80, 93: Should it say “bound or connected” instead of simply “bound”?
69, 82, 95: “RDMA based -> “RDMA-based” (add a hyphen)
69, 82, 95: I don’t think that RdmaSocketImpl should be mentioned in the javadoc as it is not in the public API.

Thanks,

Brian

> On Oct 5, 2018, at 8:23 PM, Lu, Yingqi <yingqi.lu at intel.com> wrote:
> 
> The link http://cr.openjdk.java.net/~ylu/8195160.14/ <http://cr.openjdk.java.net/~ylu/8195160.14/> is updated with the additional file jdk.internal.misc.JdkRdmaSocketImplAccess.java. It might be just me, but I needed to refresh both pages http://cr.openjdk.java.net/~ylu/8195160.14/ <http://cr.openjdk.java.net/~ylu/8195160.14/> andhttp://cr.openjdk.java.net/~ylu/8195160.14/jdk12-8195160-version14.patch <http://cr.openjdk.java.net/~ylu/8195160.14/jdk12-8195160-version14.patch> to get the updated content.   
>  
> Please let me know if you see any issues.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20181026/2c471d43/attachment.html>


More information about the nio-dev mailing list