adding rsockets support into JDK

[Lu, Yingqi]

Hi Brian,

Thank you very much for the help reviewing the APIs. I already made the changes accordingly.

Have you got any chance to look at the test cases? I plan to wait for your feedback there and send out the webrev version 15 with all the changes.

Thanks,
Lucy

From: Brian Burkhalter [mailto:brian.burkhalter at oracle.com]
Sent: Friday, October 26, 2018 12:02 PM
To: Lu, Yingqi <yingqi.lu at intel.com>
Cc: Aundhe, Shirish <shirish.aundhe at intel.com>; nio-dev at openjdk.java.net; Viswanathan, Sandhya <sandhya.viswanathan at intel.com>; Kaczmarek, Eric <eric.kaczmarek at intel.com>
Subject: Re: adding rsockets support into JDK

Hi Lucy,

For now, just a few minor points regarding the API verbiage.

1. jdk.net<http://jdk.net>.Sockets

474: I think “server-socket” should have the hyphen removed: “server socket”.

2. jdk.net<http://jdk.net>.RdmaSocketOptions

67, 80, 93: Should it say “bound or connected” instead of simply “bound”?
69, 82, 95: “RDMA based -> “RDMA-based” (add a hyphen)
69, 82, 95: I don’t think that RdmaSocketImpl should be mentioned in the javadoc as it is not in the public API.

Thanks,

Brian


On Oct 5, 2018, at 8:23 PM, Lu, Yingqi <yingqi.lu at intel.com<mailto:yingqi.lu at intel.com>> wrote:

The link http://cr.openjdk.java.net/~ylu/8195160.14/ is updated with the additional file jdk.internal.misc.JdkRdmaSocketImplAccess.java. It might be just me, but I needed to refresh both pages http://cr.openjdk.java.net/~ylu/8195160.14/ andhttp://cr.openjdk.java.net/~ylu/8195160.14/jdk12-8195160-version14.patch to get the updated content.

Please let me know if you see any issues.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20181026/6427ad1e/attachment-0001.html>