RFR (XS) 8221824: Build failure with MSVS 2013 after JDK-8218418

[Alan Bateman]

On 02/04/2019 14:04, Aleksey Shipilev wrote:
> :
> I don't think it is a good idea to define and pass in flag that is not defined by the
> toolchain/headers. I think we either do this fix, or we backout the entire changeset that currently
> breaks the builds. Yes, current fix reverts the orginal change, but _only_ for older SDKs.
> Follow-ups that make it right for everything would be appreciated.
>
It would be nice if there were some agreement on build-dev on the 
minimum SDK version to use - as I mentioned in the JIRA, we're using VS 
2017 for JDK 13 so it will be hard to not break environments that are 
using VS 2013.

Unfortunately there is long history of using #ifndef and/or 
GetProcAddress to make use of newer features while still building with 
older SDKs. So this wouldn't be the first. I don't object to your patch 
of course, I'm a lot more concerned as to how Windows 7 and 8.x behave 
when passed a flag that they do not recognize (this is a run-time issue 
rather than a build issue of course).

-Alan