RFR (XS) 8221824: Build failure with MSVS 2013 after JDK-8218418

[Aleksey Shipilev]

On 4/2/19 3:32 PM, Alan Bateman wrote:
> On 02/04/2019 14:04, Aleksey Shipilev wrote:
>> I don't think it is a good idea to define and pass in flag that is not defined by the
>> toolchain/headers. I think we either do this fix, or we backout the entire changeset that currently
>> breaks the builds. Yes, current fix reverts the orginal change, but _only_ for older SDKs.
>> Follow-ups that make it right for everything would be appreciated.
>>
> It would be nice if there were some agreement on build-dev on the minimum SDK version to use - as I
> mentioned in the JIRA, we're using VS 2017 for JDK 13 so it will be hard to not break environments
> that are using VS 2013.

Yes, that's understood. It does not mean we cannot make effort to keep it buildable :)

> Unfortunately there is long history of using #ifndef and/or GetProcAddress to make use of newer
> features while still building with older SDKs. So this wouldn't be the first. I don't object to your
> patch of course,

Okay, thanks. jdk-submit okay'ed the patch, I am going to push it shortly.

-Aleksey


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190402/6e3ae310/signature-0001.asc>