RFR: 8221397 Support implementation-defined Map Modes

[Andrew Dinn]

On 05/04/2019 10:47, Alan Bateman wrote:
> On 05/04/2019 10:24, Andrew Dinn wrote:
>> :
>> Sorry, I am afraid I don't understand what you mean by "The package
>> description has a catch-all for NPE so you need to specify that in each
>> method."
>>
>> What is the "package description"?
> package-info.java has the package description. Near the end you should
> see the statement "Unless otherwise noted, passing a null ...".   There
> are several areas of API that have statements like this to avoid
> cluttering the javadoc of every constructor/method that can throw NPE
> when invokes with a null argument. So this is why you don't see "@throws
> NullPointerException" here.
Ah ok, got it now. I think I was confused by a missing 'not' in your
original response.

I have now removed the @throws for NPE from the MapMode constructor
javadoc as well as letting the call to length() perform the null check.

new webrev: http://cr.openjdk.java.net/~adinn/8221397/webrev.00/
      JIRA: https://bugs.openjdk.java.net/browse/JDK-8221397

Testing:

Successfully runs updated MapTest
Submit job in progress

Is this ok to push (modulo submit returning ok) or do I need another
review for you and/or some other reviewer?

regards,


Andrew Dinn
-----------
Senior Principal Software Engineer
Red Hat UK Ltd
Registered in England and Wales under Company Registration No. 03798903
Directors: Michael Cunningham, Michael ("Mike") O'Neill, Eric Shander