RFR: 8222532: (zipfs) Performance regression when writing ZipFileSystem entries in parallel

Claes Redestad claes.redestad at oracle.com
Tue Apr 23 11:42:32 UTC 2019


Hi Alan, Christoph,

thanks for reviewing this!

On 2019-04-23 12:42, Alan Bateman wrote:
> On 18/04/2019 14:10, Claes Redestad wrote:
>> Webrev: http://cr.openjdk.java.net/~redestad/8222532/open.00/
> I think the approach looks good.
> 
> One thing that I think could be improved is ExChannelCloser. I think it 
> needs a better name. Also I think it should encapsulate its fields a lot 
> better so that sync doesn't need to access its interanls -- e.g. maybe 
> it can define a closeAndDelete method that closes the channel and 
> deletes the path.
> 

Based on what it does, ExChannelCloser (which I restored from its pre-
existing state) should probably be named ExistingChannelCloser.

I've collected the feedback from you, Christoph and Lance into this
new webrev: http://cr.openjdk.java.net/~redestad/8222532/open.01/

Incremental: http://cr.openjdk.java.net/~redestad/8222532/open.00_01/

Thanks!

/Claes


More information about the nio-dev mailing list