RFR: 8222532: (zipfs) Performance regression when writing ZipFileSystem entries in parallel

[Lance Andersen]

Hi Claes,

The additional updates look fine. :-)

Best
Lance
> On Apr 23, 2019, at 7:42 AM, Claes Redestad <claes.redestad at oracle.com> wrote:
> 
> Hi Alan, Christoph,
> 
> thanks for reviewing this!
> 
> On 2019-04-23 12:42, Alan Bateman wrote:
>> On 18/04/2019 14:10, Claes Redestad wrote:
>>> Webrev: http://cr.openjdk.java.net/~redestad/8222532/open.00/
>> I think the approach looks good.
>> One thing that I think could be improved is ExChannelCloser. I think it needs a better name. Also I think it should encapsulate its fields a lot better so that sync doesn't need to access its interanls -- e.g. maybe it can define a closeAndDelete method that closes the channel and deletes the path.
> 
> Based on what it does, ExChannelCloser (which I restored from its pre-
> existing state) should probably be named ExistingChannelCloser.
> 
> I've collected the feedback from you, Christoph and Lance into this
> new webrev: http://cr.openjdk.java.net/~redestad/8222532/open.01/
> 
> Incremental: http://cr.openjdk.java.net/~redestad/8222532/open.00_01/
> 
> Thanks!
> 
> /Claes

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190423/b6c8aab9/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190423/b6c8aab9/oracle_sig_logo-0001.gif>