RFR: 8229887: ZIP FS cannot replace an entry in a that was added via the STORED method

[Lance Andersen]

Thank you Martin.  I agree for the need to continue to improve coverage.  It has gotten somewhat better but definitely on the todo list.

Best
Lance
> On Aug 19, 2019, at 6:55 PM, Martin Buchholz <martinrb at google.com> wrote:
> 
> (not a review, but)
> For many years I've been helping to maintain java.util.zip, but I've mostly ignored zipfs, and zipfs spent years as a "demo", so it is probably undertested, and it would help if existing tests for e.g. ZipFile were extended to also cover zipfs when that was a natural thing to do.
> 
> On Mon, Aug 19, 2019 at 1:49 PM Lance Andersen <lance.andersen at oracle.com <mailto:lance.andersen at oracle.com>> wrote:
> Hi
> 
> The following patch for JDK-8229887 <https://bugs.openjdk.java.net/browse/JDK-8229887> addresses an issue introduced by the performance fix in https://bugs.openjdk.java.net/browse/JDK-8222532 <https://bugs.openjdk.java.net/browse/JDK-8222532> resulting in an error when trying to replace an entry in a ZIP/JAR file that was added with no-compression.
> 
> The webrev can be found at http://cr.openjdk.java.net/~lancea/8229887/webrev.00/index.html <http://cr.openjdk.java.net/~lancea/8229887/webrev.00/index.html>
> 
> Mach5 tier1 - tier3 runs are all clean with this fix.
> 
> 
> Best
> Lance
> 
> 
> 
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering 
> 1 Network Drive 
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
> 
> 
> 

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190819/0eef047b/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190819/0eef047b/oracle_sig_logo-0001.gif>