RFR: 8229887: ZIP FS cannot replace an entry in a that was added via the STORED method

Alan Bateman Alan.Bateman at oracle.com
Tue Aug 20 11:34:16 UTC 2019


On 19/08/2019 21:48, Lance Andersen wrote:
> Hi
>
> The following patch for JDK-8229887 
> <https://bugs.openjdk.java.net/browse/JDK-8229887> addresses an issue 
> introduced by the performance fix in 
> https://bugs.openjdk.java.net/browse/JDK-8222532 resulting in an error 
> when trying to replace an entry in a ZIP/JAR file that was added with 
> no-compression.
>
> The webrev can be found at 
> http://cr.openjdk.java.net/~lancea/8229887/webrev.00/index.html
>
The update to ZipFileSystem looks good.

I think the test needs a bit of work and needs to test updating zip 
files where all entries are stored, all entries are deflated, and a mix 
of the two. I've created a test that does this if you need it.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190820/d8492e8d/attachment.html>


More information about the nio-dev mailing list