RFR: 8229887: ZIP FS cannot replace an entry in a that was added via the STORED method

[Lance Andersen]

> On Aug 20, 2019, at 7:34 AM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 19/08/2019 21:48, Lance Andersen wrote:
>> Hi
>> 
>> The following patch for JDK-8229887 <https://bugs.openjdk.java.net/browse/JDK-8229887> addresses an issue introduced by the performance fix in https://bugs.openjdk.java.net/browse/JDK-8222532 <https://bugs.openjdk.java.net/browse/JDK-8222532> resulting in an error when trying to replace an entry in a ZIP/JAR file that was added with no-compression.
>> 
>> The webrev can be found at http://cr.openjdk.java.net/~lancea/8229887/webrev.00/index.html <http://cr.openjdk.java.net/~lancea/8229887/webrev.00/index.html>
> The update to ZipFileSystem looks good.

Thank you Alan
> 
> I think the test needs a bit of work and needs to test updating zip files where all entries are stored, all entries are deflated, and a mix of the two. I've created a test that does this if you need it.

A revised webrev can be found at: http://cr.openjdk.java.net/~lancea/8229887/webrev.01/index.html <http://cr.openjdk.java.net/~lancea/8229887/webrev.01/index.html>

This cleans up the existing test and adds some additional tests that were contributed by Alan.

Mach5 tier1-3 are all clean

Best
Lance

> 
> -Alan

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190821/bd409606/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190821/bd409606/oracle_sig_logo.gif>