5029431: (bf) Add absolute bulk put and get methods

Brian Burkhalter brian.burkhalter at oracle.com
Mon Feb 11 17:35:26 UTC 2019


Hi Roger,

Thanks for the comments.

> On Feb 11, 2019, at 7:12 AM, Roger Riggs <Roger.Riggs at oracle.com> wrote:
> 
> With two buffer/arrays and each with offset and length, I think the exceptions
> should identify which set of parameters is out of range.
> Using Preconditions.checkFromIndexSize directly would allow providing a formatter
> that could identify the source or dest.

As buffers are used during startup would this cause problems?

> In the examples, use the full parameter names instead of abbreviations.
> 
> 780, 1008: "off" -> "offset" since offset is used in the prose
> 
> 826, 1057, add a colon ":" after "invocation"

Agreed on both; shall update.

Thanks,

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190211/314d3064/attachment-0001.html>


More information about the nio-dev mailing list