5029431: (bf) Add absolute bulk put and get methods

[Roger Riggs]

Hi Brian,

On 02/11/2019 12:35 PM, Brian Burkhalter wrote:
> Hi Roger,
>
> Thanks for the comments.
>
>> On Feb 11, 2019, at 7:12 AM, Roger Riggs <Roger.Riggs at oracle.com 
>> <mailto:Roger.Riggs at oracle.com>> wrote:
>>
>> With two buffer/arrays and each with offset and length, I think the 
>> exceptions
>> should identify which set of parameters is out of range.
>> Using Preconditions.checkFromIndexSize directly would allow providing 
>> a formatter
>> that could identify the source or dest.
>
> As buffers are used during startup would this cause problems?
Not a problem, that is the same method invoked from Objects.checkFromToIndex
but has an argument to generate the exception.
(Which can be a instance of a static class if lambda is ruled out due to 
startup sequence).

$.02, Roger

>
>> In the examples, use the full parameter names instead of abbreviations.
>>
>> 780, 1008: "off" -> "offset" since offset is used in the prose
>>
>> 826, 1057, add a colon ":" after "invocation"
>
> Agreed on both; shall update.
>
> Thanks,
>
> Brian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190211/77ea6cbb/attachment.html>