8220738: (sc) Move ServerSocketChannelImpl remaining native method to Net

Brian Burkhalter brian.burkhalter at oracle.com
Fri Mar 15 21:38:57 UTC 2019


> On Mar 15, 2019, at 1:32 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> ServerSocketChannelImpl has one remaining native method, accept0, to accept connections. I'd like to move this to sun.nio.ch.Net <http://sun.nio.ch.net/> so that ServerSocketChannelImpl.c to be removed, along with native methods in SctpServerChannelImpl and UnixAsynchronousServerSocketChannelImpl that wrap it. This is the last of the "move native method" changes that are needed for NIO based SocketImpl that I mentioned in other mails.
> 
> At one point, someone added a wrapper in ServerSocketChannelImpl to facilitate instrumentation, I can't quite tell what this was for but the instrumentation in JFR does not use it so I think it is safe to remove.

Probably for the now obsolete resource monitoring.

> One of the SCTP tests doesn't compile since it was changed to use InetAddress.getLoopbackAddress so that is fixed too.
> 
> The webrev with the changes is here:
>    http://cr.openjdk.java.net/~alanb/8220738/webrev/index.html <http://cr.openjdk.java.net/~alanb/8220738/webrev/index.html>
This looks all right IFAICT.

Brian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20190315/ba05e199/attachment-0001.html>


More information about the nio-dev mailing list