8162520: (fs) FileStore should support file stores with > Long.MAX_VALUE capacity

Brian Burkhalter brian.burkhalter at oracle.com
Tue Oct 29 19:16:39 UTC 2019


> On Oct 19, 2019, at 12:05 PM, Alan Bateman <Alan.Bateman at oracle.com> wrote:
> 
> On 15/10/2019 18:46, Brian Burkhalter wrote:
>> 
>> An updated version which addresses the foregoing points is at http://cr.openjdk.java.net/~bpb/8162520/webrev.03/.
> Thanks, that addresses all my issues (although I'm still a bit worried that this one will come back again in the future).

Here’s an updated version [1] that does not add the get*Blocks() methods and merely changes the get*Space() methods to return Long.MAX_VALUE instead of a negative value. Adding the get*Blocks() methods may be considered later when a carrier type with greater bit depth becomes available. The test is no longer included as the get*Blocks() methods don’t need to be tested, and it is too difficult to test the negative return case for get*Space().

Thanks,

Brian

[1] http://cr.openjdk.java.net/~bpb/8162520/webrev.04/

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20191029/98b5ce45/attachment.html>


More information about the nio-dev mailing list