8162520: (fs) FileStore should support file stores with > Long.MAX_VALUE capacity

[Peter Levart]

Hi Brian,

On 10/29/19 8:16 PM, Brian Burkhalter wrote:
>
>> On Oct 19, 2019, at 12:05 PM, Alan Bateman <Alan.Bateman at oracle.com 
>> <mailto:Alan.Bateman at oracle.com>> wrote:
>>
>> On 15/10/2019 18:46, Brian Burkhalter wrote:
>>>
>>> An updated version which addresses the foregoing points is at 
>>> http://cr.openjdk.java.net/~bpb/8162520/webrev.03/.
>> Thanks, that addresses all my issues (although I'm still a bit 
>> worried that this one will come back again in the future).
>
> Here’s an updated version [1] that does not add the get*Blocks() 
> methods and merely changes the get*Space() methods to return 
> Long.MAX_VALUE instead of a negative value. Adding the get*Blocks() 
> methods may be considered later when a carrier type with greater 
> bit depth becomes available. The test is no longer included as the 
> get*Blocks() methods don’t need to be tested, and it is too difficult 
> to test the negative return case for get*Space().
>

There is a carrier type with greater (i.e. unlimited) bit depth 
available - BigInteger. Why not add 3 methods (getBigXxx...) to return 
sizes in BigInteger bytes? These are not performance critical methods 
and hence waiting for value types is not absolutely necessary.

What do you think?

Regards, Peter

> Thanks,
>
> Brian
>
> [1] http://cr.openjdk.java.net/~bpb/8162520/webrev.04/
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20191029/6f3b842a/attachment-0001.html>