RFR 8242006: (zipfs) Improve Zip FS FileChannel and SeekableByteChannel test coverage

[Langer, Christoph]

Hi Lance,

this looks like a comprising set of tests for FileChannels and ByteChannels. Thanks for adding them. ��

I didn’t find anything significant besides some formatting nits – no new webrev required of course:

line 211, 239, 377, 1326: indentation looks not quite correct yet
line 357, 385:  strange linebreak in try statement
line 1387: the comma should be in the line before to match the style of the rest of the file.

I ran a test cycle on Linux and the added tests seem to pass.

So, fine for me.

Best regards
Christoph

From: nio-dev <nio-dev-bounces at openjdk.java.net> On Behalf Of Lance Andersen
Sent: Freitag, 3. April 2020 15:24
To: nio-dev <nio-dev at openjdk.java.net>
Subject: RFR 8242006: (zipfs) Improve Zip FS FileChannel and SeekableByteChannel test coverage

Hi all,

Please review the patch for 8242006, which improves the Zip FS test coverage for FileChannel and SeekableByteChannel.

The webrev can be found at:  http://cr.openjdk.java.net/~lancea/8242006/webrev.00/index.html

Best,
Lance
[cid:image001.gif at 01D60BFF.4EB96FF0]<http://oracle.com/us/design/oracle-email-sig-198324.gif>

<http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering
1 Network Drive
Burlington, MA 01803
Lance.Andersen at oracle.com<mailto:Lance.Andersen at oracle.com>




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200406/5e243dfb/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: image001.gif
Type: image/gif
Size: 658 bytes
Desc: image001.gif
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200406/5e243dfb/image001.gif>