RFR 8242006: (zipfs) Improve Zip FS FileChannel and SeekableByteChannel test coverage

[Lance Andersen]

HI Christoph

Thank you for the review.

I corrected the formatting issues below.  I think I looked at it so many times, I just saw what I wanted to.

Doing one last Mach 5 run and will push tomorrow

Best
Lance

> On Apr 6, 2020, at 4:48 AM, Langer, Christoph <christoph.langer at sap.com> wrote:
> 
> Hi Lance,
>  
> this looks like a comprising set of tests for FileChannels and ByteChannels. Thanks for adding them. ��
>  
> I didn’t find anything significant besides some formatting nits – no new webrev required of course:
>  
> line 211, 239, 377, 1326: indentation looks not quite correct yet
> line 357, 385:  strange linebreak in try statement
> line 1387: the comma should be in the line before to match the style of the rest of the file.
>  
> I ran a test cycle on Linux and the added tests seem to pass.
>  
> So, fine for me.
>  
> Best regards
> Christoph
>  
> From: nio-dev <nio-dev-bounces at openjdk.java.net <mailto:nio-dev-bounces at openjdk.java.net>> On Behalf Of Lance Andersen
> Sent: Freitag, 3. April 2020 15:24
> To: nio-dev <nio-dev at openjdk.java.net <mailto:nio-dev at openjdk.java.net>>
> Subject: RFR 8242006: (zipfs) Improve Zip FS FileChannel and SeekableByteChannel test coverage
>  
> Hi all,
>  
> Please review the patch for 8242006, which improves the Zip FS test coverage for FileChannel and SeekableByteChannel.
>  
> The webrev can be found at:  http://cr.openjdk.java.net/~lancea/8242006/webrev.00/index.html <http://cr.openjdk.java.net/~lancea/8242006/webrev.00/index.html>
>  
> Best,
> Lance
> <image001.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
> 
>  <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
> Oracle Java Engineering 
> 1 Network Drive 
> Burlington, MA 01803
> Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>
>  
> 
> 
>  

 <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif> <http://oracle.com/us/design/oracle-email-sig-198324.gif>
 <http://oracle.com/us/design/oracle-email-sig-198324.gif>Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037
Oracle Java Engineering 
1 Network Drive 
Burlington, MA 01803
Lance.Andersen at oracle.com <mailto:Lance.Andersen at oracle.com>



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200406/f9b0a911/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: not available
URL: <https://mail.openjdk.java.net/pipermail/nio-dev/attachments/20200406/f9b0a911/oracle_sig_logo.gif>