RFR 8249773: Upgrade ReceiveISA.java test to be resilient to failure due to stray packets and interference.
Alan Bateman
Alan.Bateman at oracle.com
Thu Aug 13 09:07:35 UTC 2020
On 12/08/2020 17:00, Rahul Yadav wrote:
> Hello,
>
> Request to have my fix reviewed for issue:
>
> JDK-8249773: Upgrade ReceiveISA.java test to be resilient to failure
> due to stray packets and interference.
>
> This fix upgrades java/nio/channels/DatagramChannel/ReceiveISA.java so
> it can handle interference from stray packets,
> the test now can handle random order of packets as well.
>
> Issue: https://bugs.openjdk.java.net/browse/JDK-8249773
> webrev: http://cr.openjdk.java.net/~ryadav/webrev_8249773/index.html
Looks good, there are probably other tests that are subject to
interference like this too.
Would it be possible to rename "tmp" to "receiver" at L81 to make it
easier for future maintainers. Also "interfering" in the trace messages
might be bettered as "Interfered". Minor formatting nits: extra
semi-colon at L45, line break in odd place at L102, extra line at L88.
-Alan
More information about the nio-dev
mailing list