RFR 8249773: Upgrade ReceiveISA.java test to be resilient to failure due to stray packets and interference.

Daniel Fuchs daniel.fuchs at oracle.com
Thu Aug 13 09:30:21 UTC 2020


On 13/08/2020 09:56, Rahul Yadav wrote:
> Thank you Daniel, I have included the feedback.

Thanks Rahul!

LGTM. Good idea to generate interference within the test itself!

best regards,

-- daniel

> 
> -- rahul
> 
> On 12/08/2020 17:17, Daniel Fuchs wrote:
>> Looks good Rahul.
>>
>> Could be useful to print out the sender as well as the packet
>> message when a random interfering packet is detected.
>>
>> best regards,
>>
>> -- daniel
>>
>> On 12/08/2020 17:00, Rahul Yadav wrote:
>>> Hello,
>>>
>>> Request to have my fix reviewed for issue:
>>>
>>> JDK-8249773:  Upgrade ReceiveISA.java test to be resilient to failure 
>>> due to stray packets and interference.
>>>
>>> This fix upgrades java/nio/channels/DatagramChannel/ReceiveISA.java 
>>> so it can handle interference from stray packets,
>>> the test now can handle random order of packets as well.
>>>
>>> Issue:  https://bugs.openjdk.java.net/browse/JDK-8249773
>>> webrev: http://cr.openjdk.java.net/~ryadav/webrev_8249773/index.html
>>>
>>> - rahul
>>
> 



More information about the nio-dev mailing list