RFR 8241305: Add protocol specific factory creation methods to SocketChannel and ServerSocketChannel

Michael McMahon michael.x.mcmahon at oracle.com
Sun May 17 09:56:12 UTC 2020


On 17/05/2020 10:39, Alan Bateman wrote:
> On 17/05/2020 10:10, Michael McMahon wrote:
>>
>> Right, got you now.
> Good but what about the the outer try-finally in xxOpenBind tests? If 
> that is removed (sc, ssc, dc are not used) then it should make these 
> tests much easier to maintain. Also will allow you to drop the "1" 
> suffix from the variable names.
>
Yes, sorry I should have noticed that. The webrev is updated in place 
with that fixed.

Thanks,

Michael.

>
>> gen is already part of the name for one of the lists. So, I left it 
>> as Tests. If you
>> have a strong preference for something different, I'll change it.
> Okay, I guess it's okay.
>
> -Alan.


More information about the nio-dev mailing list