RFR 8241305: Add protocol specific factory creation methods to SocketChannel and ServerSocketChannel

[Alan Bateman]

On 17/05/2020 10:56, Michael McMahon wrote:
>
> On 17/05/2020 10:39, Alan Bateman wrote:
>> On 17/05/2020 10:10, Michael McMahon wrote:
>>>
>>> Right, got you now.
>> Good but what about the the outer try-finally in xxOpenBind tests? If 
>> that is removed (sc, ssc, dc are not used) then it should make these 
>> tests much easier to maintain. Also will allow you to drop the "1" 
>> suffix from the variable names.
>>
> Yes, sorry I should have noticed that. The webrev is updated in place 
> with that fixed.
Thanks, I think all 3 tests look much better now.

Just a couple of nits that you might want to fix up before pushing this 
(I don't need another webrev):
- The @summary on OpenAndConnect mentions "platforms" but these were all 
the problematic test scenarios that no longer exist so I think the 
summary statement can be cleaned up.
- OpenAndConnect::isNotLoopback is no longer used so can be removed
- Tidy up the imports as there are bunch of imports that aren't used 
(Predicate, Duration, parseBoolean, getProperty, ...).

-Alan